This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
fix(sample): fix a broken test #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
reviewed
Sep 18, 2020
| @@ -124,19 +124,21 @@ def update_notification_config(organization_id, notification_config_id, pubsub_t | |||
|
|
|||
| # Only description and pubsub_topic can be updated. | |||
| field_mask = field_mask_pb2.FieldMask( | |||
| paths=["description", "pubsub_topic", "streaming_config.fitler"] | |||
There was a problem hiding this comment.
Was this failing because this was a typo? fitler instead of filter?
There was a problem hiding this comment.
Oh Nice catch, I'll update :)
busunkim96
approved these changes
Sep 18, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #59
It seems like it fails when we try to update
streaming_config.filterfield.Maybe we can omit that field from the sample code for now.
@hannah-tsai FYI