This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 8, 2020
hannah-tsai
changed the title
Update Security Command Center UpdateNotificationConfig doc sample
docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field
Jul 8, 2020
Hi, |
@hannah-tsai The CI won't run unless you are a member of an org. Someone with write access needs to nudge it by adding a label. |
busunkim96
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 9, 2020
busunkim96
approved these changes
Jul 9, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 9, 2020
busunkim96
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 10, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 10, 2020
Hi, not sure if I should be concerned with the Kokoro build failure? |
Hi @hannah-tsai, Would you mind modifying this PR to change this file instead? I shuffled the snippets into a different directory in #41. |
… adding filter to mutable field
Updated change list, busunkim96@ could you help to add a label to start the Kokoro test? Thanks! |
busunkim96
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 23, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 23, 2020
busunkim96
added
automerge
Merge the pull request once unit tests and other checks pass.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jul 23, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 23, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.7.0](https://www.github.com/googleapis/python-securitycenter/compare/v0.6.0...v0.7.0) (2020-09-10) ### Features * add field severity to findings; update retry configs ([#53](https://www.github.com/googleapis/python-securitycenter/issues/53)) ([80494a9](https://www.github.com/googleapis/python-securitycenter/commit/80494a915ca33d260862694be889b817869ff01a)) ### Documentation * Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field ([#39](https://www.github.com/googleapis/python-securitycenter/issues/39)) ([c70d790](https://www.github.com/googleapis/python-securitycenter/commit/c70d7904425ae5ac252ffa7317ec6d08234a6c27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/155346619
Add "filter" to mutable fields for UpdateNotificationConfig.