Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat: add filter to customize the output of ListSecrets/ListSecretVersions calls #161

Merged
merged 2 commits into from Jul 28, 2021
Merged

feat: add filter to customize the output of ListSecrets/ListSecretVersions calls #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4dca55
feat: In Secret Manager, users can now use filter to customize the ou…
gcf-owl-bot[bot] Jul 27, 2021
9c0de5d
🦉 Updates from OwlBot
gcf-owl-bot[bot] Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions google/cloud/secretmanager_v1/types/service.py
View file
Open in desktop
Expand Up @@ -59,11 +59,18 @@ class ListSecretsRequest(proto.Message):
page_token (str):
Optional. Pagination token, returned earlier via
[ListSecretsResponse.next_page_token][google.cloud.secretmanager.v1.ListSecretsResponse.next_page_token].
filter (str):
Optional. Filter string, adhering to the rules in
`List-operation
filtering <https://cloud.google.com/secret-manager/docs/filtering>`__.
List only secrets matching the filter. If filter is empty,
all secrets are listed.
"""

parent = proto.Field(proto.STRING, number=1,)
page_size = proto.Field(proto.INT32, number=2,)
page_token = proto.Field(proto.STRING, number=3,)
filter = proto.Field(proto.STRING, number=4,)


class ListSecretsResponse(proto.Message):
Expand Down Expand Up @@ -173,11 +180,18 @@ class ListSecretVersionsRequest(proto.Message):
page_token (str):
Optional. Pagination token, returned earlier via
ListSecretVersionsResponse.next_page_token][].
filter (str):
Optional. Filter string, adhering to the rules in
`List-operation
filtering <https://cloud.google.com/secret-manager/docs/filtering>`__.
List only secret versions matching the filter. If filter is
empty, all secret versions are listed.
"""

parent = proto.Field(proto.STRING, number=1,)
page_size = proto.Field(proto.INT32, number=2,)
page_token = proto.Field(proto.STRING, number=3,)
filter = proto.Field(proto.STRING, number=4,)


class ListSecretVersionsResponse(proto.Message):
Expand Down
4 changes: 2 additions & 2 deletions scripts/fixup_secretmanager_v1_keywords.py
View file
Open in desktop
Expand Up @@ -49,8 +49,8 @@ class secretmanagerCallTransformer(cst.CSTTransformer):
'get_iam_policy': ('resource', 'options', ),
'get_secret': ('name', ),
'get_secret_version': ('name', ),
'list_secrets': ('parent', 'page_size', 'page_token', ),
'list_secret_versions': ('parent', 'page_size', 'page_token', ),
'list_secrets': ('parent', 'page_size', 'page_token', 'filter', ),
'list_secret_versions': ('parent', 'page_size', 'page_token', 'filter', ),
'set_iam_policy': ('resource', 'policy', ),
'test_iam_permissions': ('resource', 'permissions', ),
'update_secret': ('secret', 'update_mask', ),
Expand Down