This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
fix: add 'dict' type annotation to 'request' #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: secretmanager
google-cla
bot
added
the
cla: yes
tseaver
approved these changes
Sep 13, 2021
|
Oops I forgot Owlbot would try to apply the replacement more than once 馃憖 . I will adjust the regex and re-push. |
busunkim96
force-pushed
the
fix-request-type-annotation
branch
from
6cae115
to
0948413
Compare
busunkim96
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 14, 2021
馃 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/python-secret-manager/compare/v2.7.0...v2.7.1) (2021-09-13) ### Bug Fixes * add 'dict' type annotation to 'request' ([#193](https://www.github.com/googleapis/python-secret-manager/issues/193)) ([1d5fee4](https://www.github.com/googleapis/python-secret-manager/commit/1d5fee4fe825096947bb125ebcba72fdb6d463c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator version cannot currently be changed since googleapis is frozen. This PR manually applies the type annotation fix for requests.
Fixes #90 馃