Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests to support latest google-cloud-core #23

Merged
merged 3 commits into from Oct 6, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 22, 2020

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2020
@tswast tswast requested a review from a team as a code owner September 22, 2020 19:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@product-auto-label product-auto-label bot added the api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. label Sep 23, 2020
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver tseaver merged commit 1a8af71 into googleapis:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants