Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

chore: Prepare for mono repository migration #224

Merged
merged 2 commits into from Apr 17, 2023
Merged

chore: Prepare for mono repository migration #224

merged 2 commits into from Apr 17, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 15, 2023

This PR updates the owlbot.py to match the standard one to prepare for the mono repository migration.

@parthea parthea requested a review from a team as a code owner April 15, 2023 12:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: recommendationengine Issues related to the googleapis/python-recommendations-ai API. labels Apr 15, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Apr 15, 2023

from google.api import httpbody_pb2 # type: ignore
from google.api_core import (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't client_options below get included in this grouping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I'm not sure. In the future we will remove the nox -s format session when we remove post processing. We will sort imports in the generated output of the gapic generator so we don't need to rely on other tools to do it for us.


from google.api_core import gapic_v1, grpc_helpers, grpc_helpers_async, path_template

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when does it include multiple imports in one line like here, and when in multiple lines with parens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is part of black which automatically formats code which exceeds the line length limit. In the future we will remove the need to run black when we remove post processing altogether.

session.run(
"black",
*LINT_PATHS,
)

@parthea parthea self-assigned this Apr 17, 2023
@parthea parthea merged commit 53bdd71 into main Apr 17, 2023
22 checks passed
@parthea parthea deleted the parthea-patch-1 branch April 17, 2023 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: recommendationengine Issues related to the googleapis/python-recommendations-ai API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants