Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

packaging: do not include docs and tests modules #75

Closed
wants to merge 1 commit into from
Closed

packaging: do not include docs and tests modules #75

wants to merge 1 commit into from

Conversation

qbey
Copy link

@qbey qbey commented Jun 4, 2021

See. #74

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #74 馃

@qbey qbey requested a review from a team as a code owner June 4, 2021 08:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@product-auto-label product-auto-label bot added the api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. label Jun 4, 2021
owlbot.py Outdated
@@ -29,7 +29,7 @@
for library in s.get_staging_dirs("v1"):
# rename to google-cloud-recaptcha-enterprise
s.replace(
[library / "google/**/*.py", library / "tests/**/*.py"],
[library / "google/**/*.py"],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove tests here because I guess this is this what generates the MANIFEST file, but I'm not used to this tool, so it may be a mistake :)

See. #74

Do not package internal development files:
 - docs
 - scripts
 - tests
@parthea
Copy link
Contributor

parthea commented Jun 16, 2021

Hi @qbey , Thanks for submitting this PR. We've merged a fix in #79 which aligns with other repos in the googleapis org. I'm going to close this PR but please continue the discussion in the issue #74 if you still have an issue with the next published version.

@parthea parthea closed this Jun 16, 2021
@qbey qbey deleted the qbey/remove_tests_from_packaging branch June 16, 2021 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Packaging] Error prone tests and docs modules included
2 participants