Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

build: support custom samples Dockerfile for this repo #128

Closed
wants to merge 25 commits into from

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Sep 30, 2021

Allow a custom Dockerfile to be used specifically for samples inside this repository.

For #112.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2021
@product-auto-label product-auto-label bot added api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. samples Issues that are directly related to samples. labels Sep 30, 2021
@busunkim96 busunkim96 added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 30, 2021
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2021
@busunkim96 busunkim96 removed the owlbot:ignore instruct owl-bot to ignore a PR label Sep 30, 2021
@busunkim96 busunkim96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2021
@busunkim96
Copy link
Contributor Author

Hi @Sita04,

This setup should let you use a custom Dockerfile. Please merge this branch into yours, discard the placeholder samples/ directory, and modify .kokoro/docker/samples/Dockerfile.

@busunkim96 busunkim96 added the owlbot:ignore instruct owl-bot to ignore a PR label Oct 1, 2021
@busunkim96 busunkim96 removed the owlbot:ignore instruct owl-bot to ignore a PR label Oct 1, 2021
@busunkim96 busunkim96 added the owlbot:ignore instruct owl-bot to ignore a PR label Oct 1, 2021
@busunkim96 busunkim96 added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
busunkim96 added a commit to googleapis/synthtool that referenced this pull request Oct 5, 2021
…le (#1232)

* Use trampoline_v2 ([Docker CI Helper](https://github.com/GoogleCloudPlatform/docker-ci-helper)) for all python samples.
* Optionally allow samples to run with a Dockerfile specified in the library repository at `.kokoro/docker/samples`. On a successful test run, this Dockerfile is uploaded to `gcr.io/cloud-devrel-kokoro-resources/{repo-name}-samples-docker`. The option is enabled by passing `custom_samples_dockerfile=True` to `common.py_library` in `owlbot.py`.

    ```py
     templated_files = common.py_library(microgenerator=True, custom_samples_dockerfile=True)
    ```

See googleapis/python-asset#308 for an example of moving samples to to trampoline_v2.

See googleapis/python-recaptcha-enterprise#128 for an example of moving to trampoline_v2 + using a custom Dockerfile.
@busunkim96 busunkim96 closed this Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: recaptchaenterprise Issues related to the googleapis/python-recaptcha-enterprise API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants