Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move FlowControlSettings to types #53

Merged
merged 2 commits into from Oct 26, 2020
Merged

fix: Move FlowControlSettings to types #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff8fd41
fix: Move FlowControlSettings to types
dpcollins-google Oct 20, 2020
8bab5c5
fix: import
dpcollins-google Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions google/cloud/pubsublite/cloudpubsub/internal/single_partition_subscriber.py
View file
Open in desktop
Expand Up @@ -6,9 +6,7 @@
from google.cloud.pubsub_v1.subscriber.message import Message
from google.pubsub_v1 import PubsubMessage

from google.cloud.pubsublite.cloudpubsub.flow_control_settings import (
FlowControlSettings,
)
from google.cloud.pubsublite.types import FlowControlSettings
from google.cloud.pubsublite.cloudpubsub.internal.ack_set_tracker import AckSetTracker
from google.cloud.pubsublite.cloudpubsub.message_transformer import MessageTransformer
from google.cloud.pubsublite.cloudpubsub.nack_handler import NackHandler
Expand Down
4 changes: 1 addition & 3 deletions google/cloud/pubsublite/cloudpubsub/make_subscriber.py
View file
Open in desktop
Expand Up @@ -5,9 +5,7 @@
from google.api_core.client_options import ClientOptions
from google.auth.credentials import Credentials
from google.cloud.pubsub_v1.subscriber.futures import StreamingPullFuture
from google.cloud.pubsublite.cloudpubsub.flow_control_settings import (
FlowControlSettings,
)
from google.cloud.pubsublite.types import FlowControlSettings
from google.cloud.pubsublite.cloudpubsub.internal.ack_set_tracker_impl import (
AckSetTrackerImpl,
)
Expand Down
1 change: 1 addition & 0 deletions google/cloud/pubsublite/types/__init__.py
View file
Open in desktop
Expand Up @@ -2,3 +2,4 @@
from .partition import Partition
from .paths import LocationPath, TopicPath, SubscriptionPath
from .publish_metadata import PublishMetadata
from .flow_control_settings import FlowControlSettings, DISABLED_FLOW_CONTROL
0 ...lite/cloudpubsub/flow_control_settings.py → ...pubsublite/types/flow_control_settings.py
View file
Open in desktop
File renamed without changes.
4 changes: 1 addition & 3 deletions tests/unit/pubsublite/cloudpubsub/internal/single_partition_subscriber_test.py
View file
Open in desktop
Expand Up @@ -7,9 +7,7 @@
from google.cloud.pubsub_v1.subscriber.message import Message
from google.pubsub_v1 import PubsubMessage

from google.cloud.pubsublite.cloudpubsub.flow_control_settings import (
FlowControlSettings,
)
from google.cloud.pubsublite.types import FlowControlSettings
from google.cloud.pubsublite.cloudpubsub.internal.ack_set_tracker import AckSetTracker
from google.cloud.pubsublite.cloudpubsub.internal.single_partition_subscriber import (
SinglePartitionSubscriber,
Expand Down