Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move types to common directory #51

Merged
merged 2 commits into from Oct 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions google/cloud/pubsublite/admin_client.py
@@ -1,8 +1,12 @@
from abc import ABC, abstractmethod
from typing import List

from google.cloud.pubsublite.location import CloudRegion
from google.cloud.pubsublite.paths import TopicPath, LocationPath, SubscriptionPath
from google.cloud.pubsublite.types import (
CloudRegion,
TopicPath,
LocationPath,
SubscriptionPath,
)
from google.cloud.pubsublite_v1 import Topic, Subscription
from google.protobuf.field_mask_pb2 import FieldMask

Expand Down
Expand Up @@ -7,7 +7,7 @@
from google.cloud.pubsublite.internal.wait_ignore_cancelled import wait_ignore_cancelled
from google.cloud.pubsublite.internal.wire.assigner import Assigner
from google.cloud.pubsublite.internal.wire.permanent_failable import PermanentFailable
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition

PartitionSubscriberFactory = Callable[[Partition], AsyncSubscriber]

Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/cloudpubsub/make_publisher.py
Expand Up @@ -15,7 +15,7 @@
)
from google.cloud.pubsublite.internal.wire.merge_metadata import merge_metadata
from google.cloud.pubsublite.internal.wire.pubsub_context import pubsub_context
from google.cloud.pubsublite.paths import TopicPath
from google.cloud.pubsublite.types import TopicPath


DEFAULT_BATCHING_SETTINGS = WIRE_DEFAULT_BATCHING
Expand Down
9 changes: 5 additions & 4 deletions google/cloud/pubsublite/cloudpubsub/make_subscriber.py
Expand Up @@ -31,7 +31,7 @@
AsyncSubscriber,
MessageCallback,
)
from google.cloud.pubsublite.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.wire.assigner import Assigner
from google.cloud.pubsublite.internal.wire.assigner_impl import AssignerImpl
from google.cloud.pubsublite.internal.wire.committer_impl import CommitterImpl
Expand All @@ -42,9 +42,10 @@
from google.cloud.pubsublite.internal.wire.merge_metadata import merge_metadata
from google.cloud.pubsublite.internal.wire.pubsub_context import pubsub_context
import google.cloud.pubsublite.internal.wire.subscriber_impl as wire_subscriber
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.paths import SubscriptionPath
from google.cloud.pubsublite.routing_metadata import subscription_routing_metadata
from google.cloud.pubsublite.types import Partition, SubscriptionPath
from google.cloud.pubsublite.internal.routing_metadata import (
subscription_routing_metadata,
)
from google.cloud.pubsublite_v1 import (
SubscribeRequest,
InitialSubscribeRequest,
Expand Down
8 changes: 6 additions & 2 deletions google/cloud/pubsublite/internal/wire/admin_client_impl.py
Expand Up @@ -3,8 +3,12 @@
from google.protobuf.field_mask_pb2 import FieldMask

from google.cloud.pubsublite.admin_client import AdminClient
from google.cloud.pubsublite.location import CloudRegion
from google.cloud.pubsublite.paths import SubscriptionPath, LocationPath, TopicPath
from google.cloud.pubsublite.types import (
CloudRegion,
SubscriptionPath,
LocationPath,
TopicPath,
)
from google.cloud.pubsublite_v1 import (
Subscription,
Topic,
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/internal/wire/assigner.py
@@ -1,7 +1,7 @@
from abc import abstractmethod
from typing import AsyncContextManager, Set

from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition


class Assigner(AsyncContextManager):
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/internal/wire/assigner_impl.py
Expand Up @@ -12,7 +12,7 @@
ConnectionReinitializer,
)
from google.cloud.pubsublite.internal.wire.connection import Connection
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition
from google.cloud.pubsublite_v1.types import (
PartitionAssignmentRequest,
PartitionAssignment,
Expand Down
Expand Up @@ -2,7 +2,7 @@
import random

from google.cloud.pubsublite.internal.wire.routing_policy import RoutingPolicy
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition
from google.cloud.pubsublite_v1.types import PubSubMessage


Expand Down
Expand Up @@ -2,7 +2,7 @@
from typing import Set

from google.cloud.pubsublite.internal.wire.assigner import Assigner
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition


class FixedSetAssigner(Assigner):
Expand Down
7 changes: 3 additions & 4 deletions google/cloud/pubsublite/internal/wire/make_publisher.py
Expand Up @@ -3,7 +3,7 @@
from google.cloud.pubsub_v1.types import BatchSettings

from google.cloud.pubsublite.make_admin_client import make_admin_client
from google.cloud.pubsublite.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.wire.default_routing_policy import (
DefaultRoutingPolicy,
)
Expand All @@ -16,9 +16,8 @@
from google.cloud.pubsublite.internal.wire.single_partition_publisher import (
SinglePartitionPublisher,
)
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.paths import TopicPath
from google.cloud.pubsublite.routing_metadata import topic_routing_metadata
from google.cloud.pubsublite.types import Partition, TopicPath
from google.cloud.pubsublite.internal.routing_metadata import topic_routing_metadata
from google.cloud.pubsublite_v1 import InitialPublishRequest, PublishRequest
from google.cloud.pubsublite_v1.services.publisher_service import async_client
from google.api_core.client_options import ClientOptions
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/internal/wire/publisher.py
@@ -1,7 +1,7 @@
from abc import abstractmethod
from typing import AsyncContextManager
from google.cloud.pubsublite_v1.types import PubSubMessage
from google.cloud.pubsublite.publish_metadata import PublishMetadata
from google.cloud.pubsublite.types import PublishMetadata


class Publisher(AsyncContextManager):
Expand Down
Expand Up @@ -2,7 +2,7 @@

from typing import Awaitable, Optional
from google.api_core.exceptions import GoogleAPICallError, Cancelled
from google.cloud.pubsublite.status_codes import is_retryable
from google.cloud.pubsublite.internal.status_codes import is_retryable
from google.cloud.pubsublite.internal.wire.connection_reinitializer import (
ConnectionReinitializer,
)
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsublite/internal/wire/routing_policy.py
@@ -1,6 +1,6 @@
from abc import ABC, abstractmethod

from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition
from google.cloud.pubsublite_v1.types.common import PubSubMessage


Expand Down
3 changes: 1 addition & 2 deletions google/cloud/pubsublite/internal/wire/routing_publisher.py
Expand Up @@ -2,8 +2,7 @@

from google.cloud.pubsublite.internal.wire.publisher import Publisher
from google.cloud.pubsublite.internal.wire.routing_policy import RoutingPolicy
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.publish_metadata import PublishMetadata
from google.cloud.pubsublite.types import Partition, PublishMetadata
from google.cloud.pubsublite_v1 import PubSubMessage


Expand Down
Expand Up @@ -18,8 +18,7 @@
SerialBatcher,
BatchTester,
)
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.publish_metadata import PublishMetadata
from google.cloud.pubsublite.types import Partition, PublishMetadata
from google.cloud.pubsublite_v1.types import (
PubSubMessage,
Cursor,
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/pubsublite/make_admin_client.py
Expand Up @@ -3,9 +3,9 @@
from google.api_core.client_options import ClientOptions

from google.cloud.pubsublite.admin_client import AdminClient
from google.cloud.pubsublite.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.endpoints import regional_endpoint
from google.cloud.pubsublite.internal.wire.admin_client_impl import AdminClientImpl
from google.cloud.pubsublite.location import CloudRegion
from google.cloud.pubsublite.types import CloudRegion
from google.cloud.pubsublite_v1 import AdminServiceClient
from google.auth.credentials import Credentials

Expand Down
4 changes: 4 additions & 0 deletions google/cloud/pubsublite/types/__init__.py
@@ -0,0 +1,4 @@
from .location import CloudRegion, CloudZone
from .partition import Partition
from .paths import LocationPath, TopicPath, SubscriptionPath
from .publish_metadata import PublishMetadata
Expand Up @@ -2,7 +2,7 @@

from google.api_core.exceptions import InvalidArgument

from google.cloud.pubsublite.location import CloudZone
from google.cloud.pubsublite.types.location import CloudZone


class LocationPath(NamedTuple):
Expand Down
Expand Up @@ -2,7 +2,7 @@
import json

from google.cloud.pubsublite_v1.types.common import Cursor
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types.partition import Partition


class PublishMetadata(NamedTuple):
Expand Down
Expand Up @@ -13,7 +13,7 @@
)
from google.cloud.pubsublite.cloudpubsub.subscriber import AsyncSubscriber
from google.cloud.pubsublite.internal.wire.assigner import Assigner
from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition
from google.cloud.pubsublite.testing.test_utils import wire_queues, Box

# All test coroutines will be treated as marked.
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/pubsublite/internal/wire/assigner_impl_test.py
Expand Up @@ -14,7 +14,7 @@
)
from google.api_core.exceptions import InternalServerError

from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition
from google.cloud.pubsublite_v1.types.subscriber import (
PartitionAssignmentRequest,
InitialPartitionAssignmentRequest,
Expand Down
@@ -1,7 +1,7 @@
import json
import os

from google.cloud.pubsublite.partition import Partition
from google.cloud.pubsublite.types import Partition

from google.cloud.pubsublite.internal.wire.default_routing_policy import (
DefaultRoutingPolicy,
Expand Down