Commits on Sep 14, 2021

1. fix: Race conditions and performance issues …

   There are two main retrying_connection race conditions fixed here:
   
   1) Improper handling of cancelled write tasks can cause set_exception to be called when the task is already cancelled, which raises an InvalidStateError which is never caught by the existing code.
   2) There is a race where if reinitialize() is called after queues are cycled, meaning a poller from the old instance of the class can add a message to the new queues. This has been fixed by splitting the ConnectionReinitializer interface into "stop_processing" and "reinitialize" parts.
   
   Also fix other performance issues identified in profiles.

   

   dpcollins-google committed Sep 14, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for bb4e0b6
   • Browse repository at this point

   Copy the full SHA

   bb4e0b6 View commit details

   Browse the repository at this point in the history

2. fix: Race conditions and performance issues …

   There are two main retrying_connection race conditions fixed here:
   
   1) Improper handling of cancelled write tasks can cause set_exception to be called when the task is already cancelled, which raises an InvalidStateError which is never caught by the existing code.
   2) There is a race where if reinitialize() is called after queues are cycled, meaning a poller from the old instance of the class can add a message to the new queues. This has been fixed by splitting the ConnectionReinitializer interface into "stop_processing" and "reinitialize" parts.
   
   Also fix other performance issues identified in profiles.

   

   dpcollins-google committed Sep 14, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for c72eedb
   • Browse repository at this point

   Copy the full SHA

   c72eedb View commit details

   Browse the repository at this point in the history