Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not crash if pubsublite distribution can not be found when extracting semver #120

Merged
merged 13 commits into from Apr 21, 2021
Merged

fix: do not crash if pubsublite distribution can not be found when extracting semver #120

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
03951be
feat: adding ability to create subscriptions at head
hannahrogers-google Feb 24, 2021
2064449
Merge branch 'master' of github.com:googleapis/python-pubsublite into…
hannahrogers-google Feb 24, 2021
94d0fed
fix: lint errors
hannahrogers-google Feb 24, 2021
730a278
fix: remove absl dependency
hannahrogers-google Mar 4, 2021
1e508b2
Merge branch 'master' of github.com:googleapis/python-pubsublite into…
hannahrogers-google Mar 11, 2021
cfad1e0
fix: lint
hannahrogers-google Mar 16, 2021
92609d3
Merge pull request #1 from hannahrogers-google/seek-to-head
hannahrogers-google Mar 16, 2021
02694ad
feat: use default keyword args
hannahrogers-google Mar 16, 2021
13a571a
Merge branch 'master' of github.com:googleapis/python-pubsublite
hannahrogers-google Mar 16, 2021
abf1a4f
fix: rename offset location to backlog location
hannahrogers-google Mar 17, 2021
c7279ad
fix: broken samples
hannahrogers-google Mar 18, 2021
bb03a4d
Merge branch 'master' of github.com:googleapis/python-pubsublite
hannahrogers-google Apr 21, 2021
700fb7d
fix: do not crash if pubsublite distribution can not be found when ex…
hannahrogers-google Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion google/cloud/pubsublite/internal/wire/pubsub_context.py
View file
Open in desktop
Expand Up @@ -29,7 +29,13 @@ class _Semver(NamedTuple):


def _version() -> _Semver:
version = pkg_resources.get_distribution("google-cloud-pubsublite").version
try:
version = pkg_resources.get_distribution("google-cloud-pubsublite").version
except pkg_resources.DistributionNotFound:
_LOGGER.info(
"Failed to extract the google-cloud-pubsublite semver version. DistributionNotFound."
)
return _Semver(0, 0)
splits = version.split(".")
if len(splits) != 3:
_LOGGER.info(f"Failed to extract semver from {version}.")
Expand Down