fix: Enable pytype on Pub/Sub Lite repo and fix all errors #214
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
google/cloud/pubsublite/cloudpubsub/internal/single_publisher.py
Outdated
Show resolved
Hide resolved
| "subscription_id": path.name, | ||
| "skip_backlog": (starting_offset == BacklogLocation.END), | ||
| } | ||
| request=CreateSubscriptionRequest( |
There was a problem hiding this comment.
This is potentially a breaking behavior change due to some known issues in proto-plus if you have any users that have passed in a subscription as a dictionary
googleapis/proto-plus-python#161 comes to mind, but I think there was another one specifically about mixing dictionaries and protos, but I'm having trouble finding it.
There was a problem hiding this comment.
Acknowledged. I'm okay with this- the type hints tell the user the exact type they need to pass. I don't think this library has wide enough usage that its expected to be bug-compatable with past versions: this is only a breaking change if proto-plus-python has a bug preventing usage of a dict where it should be usable, and the user is ignoring the type hint provided on the method.
There was a problem hiding this comment.
I haven't looked closely enough to know whether it's a breaking change or not, but if it is, we should update the issue title to not use chore accordingly.
dpcollins-google
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
dpcollins-google
changed the title
🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.2](https://www.github.com/googleapis/python-pubsublite/compare/v1.1.1...v1.1.2) (2021-09-13) ### Bug Fixes * Enable pytype on Pub/Sub Lite repo and fix all errors ([#214](https://www.github.com/googleapis/python-pubsublite/issues/214)) ([df58fdf](https://www.github.com/googleapis/python-pubsublite/commit/df58fdfc83bdc4f6f753f664365a0ff26d3201e7)) * performance issues with subscriber client ([#232](https://www.github.com/googleapis/python-pubsublite/issues/232)) ([78a47b2](https://www.github.com/googleapis/python-pubsublite/commit/78a47b2817bee4a468f8ce15fe437165be1d1458)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Workarounds for google/pytype#977 and google/pytype#978 are present in this PR, as well as a backport of googleapis/gapic-generator-python#970
Also modifies construction of CreateSubscriptionRequests slightly