fix: Numerous small performance and correctness issues #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
| _Key = TypeVar("_Key") | ||
| _Client = TypeVar("_Client") | ||
|
|
||
|
|
||
| class ClientMultiplexer(Generic[_Key, _Client]): | ||
| _OpenedClientFactory = Callable[[], _Client] | ||
| _OpenedClientFactory = Callable[[_Key], _Client] |
There was a problem hiding this comment.
There was a lot of "self" time in get_or_create callers from constructing the factory to pass in. This is in the publish hot path, hence this change
| _closer: _ClientCloser | ||
| _lock: asyncio.Lock | ||
| _live_clients: Dict[_Key, _Client] | ||
| _live_clients: Dict[_Key, Awaitable[_Client]] |
There was a problem hiding this comment.
There was a lot of time in acquiring the lock in the publish hotpath- this change makes the lock not necessary
| @@ -40,22 +38,16 @@ class MultiplexedSubscriberClient(SubscriberClientInterface): | |||
| _executor: ThreadPoolExecutor | |||
| _underlying_factory: AsyncSubscriberFactory | |||
|
|
|||
| _multiplexer: ClientMultiplexer[SubscriptionPath, StreamingPullFuture] | |||
| _lock: Lock | |||
| _live_clients: Set[StreamingPullFuture] | |||
There was a problem hiding this comment.
Previously, the subscriber enforced that there was only one open subscription stream per-subscription per-client, but there's actually no need for this.
| return item.response_future | ||
|
|
||
| def should_flush(self) -> bool: | ||
| return self._tester.test(item.request for item in self._requests) | ||
| def size(self) -> BatchSize: |
There was a problem hiding this comment.
Most of the CPU in the publish path was in should_flush calls, which had to construct an iterable and iterate through every time.
| element_count=1, byte_count=PubSubMessage.pb(request).ByteSize() | ||
| ) | ||
|
|
||
| def _should_flush(self) -> bool: |
There was a problem hiding this comment.
if you'll note on the left... batching settings were previously ignored
manuelmenzella-google
approved these changes
Aug 16, 2021
dpcollins-google
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
馃 I have created a release \*beep\* \*boop\* --- ### [1.1.1](https://www.github.com/googleapis/python-pubsublite/compare/v1.1.0...v1.1.1) (2021-09-07) ### Bug Fixes * Add workaround for grpc/grpc#25364 ([#213](https://www.github.com/googleapis/python-pubsublite/issues/213)) ([e417bf3](https://www.github.com/googleapis/python-pubsublite/commit/e417bf39fe32c995e5ac2e0a807a10fee3f37d9f)) * Numerous small performance and correctness issues ([#211](https://www.github.com/googleapis/python-pubsublite/issues/211)) ([358a1d8](https://www.github.com/googleapis/python-pubsublite/commit/358a1d8a429086ee75373260eb087a9dd171e3e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 馃