fix: Remove Future type hint from return type which fails to type che…

…ck when overridden (#133)
googleapis · May 5, 2021 · abe9b14 · abe9b14
1 parent 811434e
commit abe9b14
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/google/cloud/pubsublite/cloudpubsub/internal/multiplexed_publisher_client.py b/google/cloud/pubsublite/cloudpubsub/internal/multiplexed_publisher_client.py
@@ -47,7 +47,7 @@ def publish(
         data: bytes,
         ordering_key: str = "",
         **attrs: Mapping[str, str]
-    ) -> "Future[str]":
+    ) -> Future:
         if isinstance(topic, str):
             topic = TopicPath.parse(topic)
         publisher = self._multiplexer.get_or_create(

diff --git a/google/cloud/pubsublite/cloudpubsub/internal/publisher_impl.py b/google/cloud/pubsublite/cloudpubsub/internal/publisher_impl.py
@@ -35,7 +35,7 @@ def __init__(self, underlying: AsyncSinglePublisher):
 
     def publish(
         self, data: bytes, ordering_key: str = "", **attrs: Mapping[str, str]
-    ) -> "Future[str]":
+    ) -> Future:
         return self._managed_loop.submit(
             self._underlying.publish(data=data, ordering_key=ordering_key, **attrs)
         )

diff --git a/google/cloud/pubsublite/cloudpubsub/publisher_client.py b/google/cloud/pubsublite/cloudpubsub/publisher_client.py
@@ -94,7 +94,7 @@ def publish(
         data: bytes,
         ordering_key: str = "",
         **attrs: Mapping[str, str]
-    ) -> "Future[str]":
+    ) -> Future:
         self._require_stared.require_started()
         return self._impl.publish(
             topic=topic, data=data, ordering_key=ordering_key, **attrs

diff --git a/google/cloud/pubsublite/cloudpubsub/publisher_client_interface.py b/google/cloud/pubsublite/cloudpubsub/publisher_client_interface.py
@@ -67,7 +67,7 @@ def publish(
         data: bytes,
         ordering_key: str = "",
         **attrs: Mapping[str, str],
-    ) -> "Future[str]":
+    ) -> Future:
         """
     Publish a message.
 
@@ -78,7 +78,8 @@ def publish(
       **attrs: Additional attributes to send.
 
     Returns:
-      A future completed with an ack id, which can be decoded using MessageMetadata.decode.
+      A future completed with an ack id of type str, which can be decoded using
+      MessageMetadata.decode.
 
     Raises:
       GoogleApiCallError: On a permanent failure.