Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Changed Python 2 EOL notice from future to present #98

Closed
wants to merge 1 commit into from

Conversation

OrBin
Copy link

@OrBin OrBin commented May 9, 2020

The library has a Python 2 EOL notice in the docs.
Since the set date has passed, I've changed the phrasing from future to present.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2020
@plamut
Copy link
Contributor

plamut commented May 11, 2020

@OrBin Thanks for the pull request, although the library is currently still compatible with Python 2, because the last Python 2 update actually happened in late April 2020 to include the fixes done before the end of 2019.

@busunkim96 What should be the exact wording across libraries? Technically, we still support Python 2 and we have not yet made a release that is not compatible with it, at least not in PubSub.

Thanks!

@busunkim96
Copy link
Contributor

I'd prefer to keep the current wording and change it when the library officially stops working with 2. Open to other ideas though.

@plamut
Copy link
Contributor

plamut commented May 12, 2020

While far from ideal, the old wording describes the current state of affairs slightly better, IMO.

To me it looks like a neglected future notice added before 2020, while using the past tense would actually make the claim about dropped Python 2 support stronger - which has not come into effect yet.

Let's put this PR on hold until the reality matches the new wording better. :)

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 12, 2020
@OrBin
Copy link
Author

OrBin commented May 13, 2020

Sounds good to me.
Another option is rewording to fit the current state, but I guess that's OK too.
Do you expect to release a new version soon?

@plamut
Copy link
Contributor

plamut commented May 13, 2020

@OrBin From what I heard, some of the Google Cloud Python client libraries will start dropping Python 2.7 support in the near future, though no concrete day for PubSub yet.

As for the next PubSub release - one minor release was made yesterday, and the next one will likely follow some time after publisher flow control is added (PR #96). The latter will still retain Python 2.7 compatibility.

@plamut
Copy link
Contributor

plamut commented Jul 16, 2020

Closing in favor of #158, the latter will make the exact changes that are consistent with docs changes in other libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants