Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add pubsub emulator support to schemas #651

Closed
wants to merge 3 commits into from

Conversation

bealsao
Copy link

@bealsao bealsao commented Apr 10, 2022

Hi All,

This is a submission to resolve issue #647 that I submitted.

The schema_service/client.py did not receive the fixes in this change: #297

So you receive the same errors as described in the issue: #290

Fixes #647

@bealsao bealsao requested review from a team as code owners April 10, 2022 23:51
@google-cla
Copy link

google-cla bot commented Apr 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 10, 2022
@bealsao bealsao changed the title Add pubsub emulator support to schemas fix: Add pubsub emulator support to schemas Apr 11, 2022
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@acocuzzo
Copy link
Contributor

Hi @bealsao
Thanks so much. Because what you are changing is auto-generated code, we actually have to change our owlbot.py file to add the emulator support to our schema_service file, and then regenerate the library, so that this change is not reverted. I'm happy to do this in a separate PR that I'll link to the issue. Thanks again for your contribution!

@acocuzzo acocuzzo closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema api not supporting pubsub emulator
4 participants