Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: block until the streaming pull shuts down #424

Merged
merged 1 commit into from Jun 14, 2021
Merged

docs: block until the streaming pull shuts down #424

merged 1 commit into from Jun 14, 2021

Commits on Jun 3, 2021

  1. docs: block until the streaming pull shuts down 

    If subscriber client is used as a context manager, we need to block
until the shutdown is complete before leaving the `with` block.
If not, errors can occur if the underlying gRPC channel is closed before
subscriber client makes the final RPC requests to the server (e.g. auto
NACK anny remaining messages).
    @plamut
    plamut committed Jun 3, 2021
    Copy the full SHA
    7fb5f93 View commit details
    Browse the repository at this point in the history