Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACK deadline set for received messages can be too low #416

Merged
merged 6 commits into from May 26, 2021

Commits on May 20, 2021

  1. fix: use the same initial ACK deadline as leaser

    When a message is received, the initial MODACK value used should be
    the same value currently used by leaser. This makes sure the leaser
    will wake up and extend the ACK deadline before the initial one
    expires.
    plamut committed May 20, 2021
    Copy the full SHA
    223a986 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Make max_duration_per_lease_extension high enough

    If flow_control.max_duration_per_lease_extension is set to too low a
    value, it is adjusted to the minimum ACK deadline.
    plamut committed May 21, 2021
    Copy the full SHA
    dc2b233 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    aed7784 View commit details
    Browse the repository at this point in the history
  3. Only update ACK deadline through leaser

    The ACK deadline is dynamically being adjusted based on ACK data,
    but an updated deadline value must not be used for the new messages
    that arrive while the leaser thread is still sleeping.
    
    Doing so could result in the messages' ACK deadlines expiring before
    the leaser wakes up and has a chance of extending the deadlines for
    these messages. An updated ACK deadline value for new messages is thus
    only used when the leaser starts using it, too.
    plamut committed May 21, 2021
    Copy the full SHA
    ee29da4 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Copy the full SHA
    64e4d7a View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d772cab View commit details
    Browse the repository at this point in the history