New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to owl bot #411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to test this before submitting?
@pradn I had the exact same question. The docs are in the making, but until then, the steps posted here should be sufficient to run the bot locally and test how it performs. I'll try it out myself too early next week. |
Docs to learn more about this: |
I don't have access to Google internals. :) I was not able to pull an image from |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthea Thanks, that was helpful! Missed that new CI check, as it was hidden (the checklist is collapsed by default).
I successfully built and uploaded the image to "our" development Google Cloud project, pulled it, and ran it locally - it worked like a charm.
I also verified that a replacement rule change in owlbot.py
was indeed reflected in the generated code.
Looking forward to the docs update to explain how to run owlbot locally when developing, but as far as this PR is concerned, I think it's good.
One minor thing (not a blocker) - the CI check say it successfully ran 9 steps, but without any details. What would be the best way to diagnose any errors if that check fails? (possible example: a bad replacement rule in |
@pradn Do you have anything to add here? |
Let's just wait with merging until the release PR is done. |
Let's wait for googleapis/repo-automation-bots#1790 to see if that helps to view logs from owl bot. |
Release completed (last week already). Still not sure if we should merge this, though, because it would be quite impractical for external contributors to build their own Docker images and upload them to where they can actually access them. |
@plamut Sounds good. Let's wait for googleapis/repo-automation-bots#1790 |
For the record - after #299 is merged, we need to port its changes to |
@parthea Do we have an update on this? I noticed in #451 that the library suffers from the Please advise, thanks! |
Hi @plamut , I've pushed a new image to |
@parthea Ran out of time today for Pub/Sub, but will try it net week. |
I ran these commands to copy the generated code for pubsub from googleapis-gen.
You should now be able to run the last 2 commands. The |
My initial thought is that we should go ahead and merge this without waiting for the
|
@parthea If we can count on support in uncommon cases when manual intervention might be required, I'd say let's move things forward and complete the transition. Especially because keeping this open is prone to additional merge conflicts, the process requiring special handling of this library, and other overhead. I'll wait for @pradn to also have a look. |
Looks good, thanks! |
FWIW, I tried running the two commands from above and it worked like a charm. I successfully generated new changes locally (a new Samples section in CONTRIBUTING.rst in this particular case). |
This PR migrates from autosynth to owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run
synthtool
to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates.