Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make publish futures compatible with concurrent.futures.as_completed() #397

Merged
merged 6 commits into from May 15, 2021
Merged

feat: make publish futures compatible with concurrent.futures.as_completed() #397

merged 6 commits into from May 15, 2021

Commits on Apr 26, 2021

  1. feat: make futures compatible with as_completed() 

    The futures implementation is adjusted to work well with the built-in
function with the same name in `concurrent.futures` package.
    @plamut
    plamut committed Apr 26, 2021
    Copy the full SHA
    318676a View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Fix two unit tests in pre-Python 3.8 

    If setting a result/exception on a concurrent.futures.Future object,
an exception is raised only in Python3.8+, thus we conditionally
disable two unit tests.

This behavior change is fine, though, because users should never use
the set_result() and set_exception() methods directly.
    @plamut
    plamut committed Apr 27, 2021
    Copy the full SHA
    64d0d6c View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Cover missing code line with a test

    @plamut
    plamut committed Apr 28, 2021
    Copy the full SHA
    46b1607 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Use double underscore for internal cancelled flag

    @plamut
    plamut committed May 14, 2021
    Copy the full SHA
    bb3dd72 View commit details
    Browse the repository at this point in the history

  2. Prefix manager reference with double underscore

    @plamut
    plamut committed May 14, 2021
    Copy the full SHA
    79f11b6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Remove Future's completed parameter altogether 

    This parameter is unlikely to be used by any 3rd party code, but
even if it is, it's better to cause a loud error rather than silently
changing its effect to a no-op.
    @plamut
    plamut committed May 15, 2021
    Copy the full SHA
    6c8b501 View commit details
    Browse the repository at this point in the history