Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move await_msg_callbacks flag to subscribe() method #320

Merged
merged 6 commits into from Mar 24, 2021
Merged

fix: move await_msg_callbacks flag to subscribe() method #320

merged 6 commits into from Mar 24, 2021

Commits on Mar 10, 2021

  1. Revert "revert: add graceful streaming pull shutdown (googleapis#315)" 

    This reverts commit 16bf588.
    @plamut
    plamut committed Mar 10, 2021
    Copy the full SHA
    eed9759 View commit details
    Browse the repository at this point in the history

  2. Move await_msg_callbacks to subscribe() method 

    This is to keep the StreamingPullFuture's surface intact for
compatibility with PubSub Lite client.
    @plamut
    plamut committed Mar 10, 2021
    Copy the full SHA
    c61186b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Make streaming pull close() method non-blocking

    @plamut
    plamut committed Mar 12, 2021
    Copy the full SHA
    79b8c00 View commit details
    Browse the repository at this point in the history

  2. Add a blocking streaming pull shutdown sample

    @plamut
    plamut committed Mar 12, 2021
    Copy the full SHA
    0fc2197 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Merge branch 'master' into iss-318

    @plamut
    plamut committed Mar 17, 2021
    Copy the full SHA
    fd176f5 View commit details
    Browse the repository at this point in the history

  2. Refine docs on awaiting callbacks on shutdown

    @plamut
    plamut committed Mar 17, 2021
    Copy the full SHA
    f696ee6 View commit details
    Browse the repository at this point in the history