Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): mitigate flakiness in subscriber_test #304

Merged
merged 6 commits into from Mar 2, 2021

Commits on Mar 2, 2021

  1. fix(sample): mitigate flakiness in subscriber_test

    fixes googleapis#289
    fixes googleapis#288
    
    I think there were few problems with the tests.
    
    1. google.api_core.exceptions.Unknown is not retried.
    2. number of messages published in test_receive_synchronously_with_lease
       was 5, but the sample code is fetching 3 messages in bulk.
    3. assertion in test_receive_synchronously_with_lease was too strict.
    4. failure in subscriber_test was incorrectly considered a failure in
       teardown of quickstart_test.
    
    I hope these changes will mitigate the flakiness.
    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    55377df View commit details
    Browse the repository at this point in the history
  2. lint

    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    e28c42f View commit details
    Browse the repository at this point in the history
  3. also retry NotFound for dlq subscription

    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    bc301ea View commit details
    Browse the repository at this point in the history
  4. lint

    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    d2b9903 View commit details
    Browse the repository at this point in the history
  5. ignore NotFound on deletion

    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    cd4c767 View commit details
    Browse the repository at this point in the history
  6. lint

    Takashi Matsuo committed Mar 2, 2021
    Copy the full SHA
    ef4d96b View commit details
    Browse the repository at this point in the history