Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customizable retry and timeout settings on the publisher client #299

Merged
merged 19 commits into from Jun 15, 2021
Merged

feat: support customizable retry and timeout settings on the publisher client #299

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
729a5e7
feat: allow retry and timeout settings on publisher client
cguardia Nov 16, 2020
a9b5190
build: update generated code and update doc
cguardia Nov 16, 2020
1b8767b
Merge branch 'master' into retry-timeout-settings
cguardia Dec 3, 2020
b06d122
Merge branch 'master' into retry-timeout-settings
cguardia Dec 4, 2020
54a1fd6
Merge branch 'master' into iss-222
plamut Feb 25, 2021
12f2140
Propagate publish timeout to the RPC call
plamut Feb 26, 2021
240f992
test publisher client
plamut Feb 26, 2021
272ccdc
Fix timeout parameter type in docstrings
plamut Feb 26, 2021
a0a1fcb
Apply timeout changes to async publisher client
plamut Feb 26, 2021
2d0046c
Merge branch 'master' into iss-222
plamut Feb 26, 2021
3ad5779
Merge branch 'master' into iss-222
plamut Apr 28, 2021
ce8daea
Introduce TimeoutType type alias
plamut May 27, 2021
2adaba1
Update PublisherOptions docs
plamut May 27, 2021
072d636
Use type alias for timeout in upgrading guide
plamut May 27, 2021
44d94b8
Widen timeout types in generated publisher clients
plamut May 28, 2021
d1f0294
Use TimeoutType in handwritten code
plamut May 28, 2021
05b556e
Remove redundant backslash
plamut May 28, 2021
762b129
Use DEFAULT as a defualt timeout in base sequencer
plamut May 28, 2021
b7939d1
Do not accept plain None as a valid timeout
plamut May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions google/cloud/pubsub_v1/types.py
View file
Open in desktop
Expand Up @@ -18,10 +18,12 @@
import enum
import inspect
import sys
from typing import Union

import proto

from google.api import http_pb2
import google.api_core
from google.api_core import gapic_v1
from google.iam.v1 import iam_policy_pb2
from google.iam.v1 import policy_pb2
Expand All @@ -37,6 +39,16 @@
from google.pubsub_v1.types import pubsub as pubsub_gapic_types


TimeoutType = Union[
None,
Copy link
Contributor

@jimfulton jimfulton May 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we mean to add None? Was this my fault?

This feels like an unintentional change. We didn't accept None before.

If we want to accept None, then I think we should update

https://github.com/googleapis/python-api-core/blob/7337c6b123735fb9ae5d0e54b4399275719c020c/google/api_core/gapic_v1/method.py#L66-L67

to treat None like DEFAULT.

Copy link
Contributor Author

@plamut plamut May 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we did, even though the argument description says otherwise. But the generated code actually used None as a default value for a supposedly float-only argument. :)

int,
float,
google.api_core.timeout.ConstantTimeout,
google.api_core.timeout.ExponentialTimeout,
]
"""The type of the timeout parameter of publisher client methods."""


# Define the default values for batching.
#
# This class is used when creating a publisher or subscriber client, and
Expand Down Expand Up @@ -206,6 +218,7 @@ def _get_protobuf_messages(module):
_local_modules = [pubsub_gapic_types]

names = [
"TimeoutType",
"BatchSettings",
"LimitExceededBehavior",
"PublishFlowControl",
Expand Down