Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky samples tests #263

Merged
merged 2 commits into from Dec 21, 2020
Merged

fix: flaky samples tests #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7734fed
chore: turn off type hints
anguillanneuf Dec 21, 2020
90f1d8f
fix: try get instead of delete
anguillanneuf Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/snippets/noxfile_config.py
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@
"ignored_versions": ["2.7"],
# Old samples are opted out of enforcing Python type hints
# All new samples should feature them
"enforce_type_hints": True,
"enforce_type_hints": False,
# An envvar key for determining the project id to use. Change it
# to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
# build specific Cloud project. You can also use your own string
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/subscriber_test.py
View file
Open in desktop
Expand Up @@ -145,7 +145,7 @@ def subscription_dlq(subscriber_client, topic, dead_letter_topic):
)

try:
subscription = subscriber_client.delete_subscription(
subscription = subscriber_client.get_subscription(
request={"subscription": subscription_path}
)
except NotFound:
Expand Down