fix: fix mtls issue in handwritten layer #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
anguillanneuf
suggested changes
Oct 21, 2020
anguillanneuf
approved these changes
Oct 21, 2020
busunkim96
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #224
GAPIC client has mtls logic, which determines the api endpoint (mtls endpoint vs regular endpoint) and ssl credentials for the channel. The handwritten layer client creates its own channel, and mtls logic is completely missing. The solution is: creating a helper GAPIC client, which uses its own mtls logic to determine the mtls info (api endpoint and ssl credentials), then we can use these mtls info in the handwritten layer client initialization.
The changes are in the following 4 files:
google/cloud/pubsub_v1/publisher/client.pygoogle/cloud/pubsub_v1/subscriber/client.pytests/unit/pubsub_v1/publisher/test_publisher_client.pytests/unit/pubsub_v1/subscriber/test_subscriber_client.pyAll the other files are re-generated with synthtool (they are some test/sample scripts etc).