Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PubSub incompatibility with api-core 1.17.0+ #103

Merged
merged 10 commits into from Jun 9, 2020
Merged

fix: PubSub incompatibility with api-core 1.17.0+ #103

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
17682b4
fix: disable pre-fetching first streaming pull item
plamut May 22, 2020
eeb0634
Remove api-core version cap, but ban 1.17.0 release
plamut May 22, 2020
1d24853
Regenerate gapic layer with synth
plamut May 22, 2020
dfe21a9
Merge branch 'master' into iss-93
plamut Jun 3, 2020
00a301e
Revert "Regenerate gapic layer with synth"
plamut Jun 4, 2020
42ce69c
Retain only the relevant fix in generated code
plamut Jun 4, 2020
c7cc4b3
Merge branch 'master' into iss-93
plamut Jun 9, 2020
ba608a7
Exclude multiple incompatible api-core versions
plamut Jun 9, 2020
feff7c7
Fix syntax error in synth.py
plamut Jun 9, 2020
a975e7b
Ban all bugfix versions of problematic api-core minor versions
plamut Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Expand Up @@ -29,10 +29,10 @@
# 'Development Status :: 5 - Production/Stable'
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
# google-api-core[grpc] 1.17.0 causes problems with stream recovery, thus
# it should not be used.
# google-api-core[grpc] 1.17.0 up to 1.19.1 causes problems with stream
# recovery, thus those versions should not be used.
# https://github.com/googleapis/python-pubsub/issues/74
"google-api-core[grpc] >= 1.14.0, != 1.17.0",
"google-api-core[grpc] >= 1.14.0, != 1.17.0, != 1.18.0, != 1.19.0, != 1.19.1",
plamut marked this conversation as resolved.
Show resolved Hide resolved
"grpc-google-iam-v1 >= 0.12.3, < 0.13dev",
'enum34; python_version < "3.4"',
]
Expand Down