Skip to content

fix: use fresh context cache for each transaction#409

Merged
chrisrossi merged 3 commits intogoogleapis:masterfrom
chrisrossi:fix-394-part-deux
Apr 30, 2020
Merged

fix: use fresh context cache for each transaction#409
chrisrossi merged 3 commits intogoogleapis:masterfrom
chrisrossi:fix-394-part-deux

Conversation

@chrisrossi
Copy link
Contributor

In order to enforce transactional integrity, the context cache can't be shared
across transactions.

Fixes #394 (again)

In order to enforce transactional integrity, the context cache can't be shared
across transactions.

Fixes googleapis#394 (again)
@chrisrossi chrisrossi requested a review from cguardia April 29, 2020 19:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks.

@cguardia
Copy link
Contributor

@chrisrossi you'll have to run it through blacken.

@chrisrossi
Copy link
Contributor Author

@busunkim96 @andrewsg @crwilcox Is there a way to kick googlebot to recheck CLA? The CLA is free and clear but googlebot seems to be confused about it.

@chrisrossi chrisrossi merged commit 5109b91 into googleapis:master Apr 30, 2020
@chrisrossi chrisrossi deleted the fix-394-part-deux branch April 30, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transactions do not work

3 participants