fix: do not allow empty key parts for key constructor in namespaced model#401
Merged
cguardia merged 7 commits intogoogleapis:masterfrom Apr 29, 2020
Merged
Conversation
googlebot
added
the
cla: yes
cguardia
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chrisrossi
suggested changes
Apr 27, 2020
Contributor
chrisrossi
left a comment
chrisrossi
left a comment
There was a problem hiding this comment.
I think given that this isn't the first issue with serialization, it might make sense to have some regression tests explicitly for pickling/unpickling, so we can make sure that continues to work. Perhaps we could borrow the customer's tests from #384
Contributor
Author
|
@chrisrossi right you are. Added tests for serialization. |
chrisrossi
approved these changes
Apr 28, 2020
tests/system/test_crud.py
Outdated
|
|
||
| @pytest.mark.usefixtures("client_context") | ||
| def test_serialization(dispose_of): | ||
| """Regression test for #843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #384