fix: handle empty batches from Firestore#396
Merged
chrisrossi merged 2 commits intogoogleapis:masterfrom Apr 24, 2020
Merged
Conversation
For some queries, when paging through batches of results, Firestore will return a batch that has no results, even though there are still results left to return for the query. Previously, this would cause `QueryIterator` to prematurely stop iterating over results. Empty batches are now handled and skipped so that `QueryIterator` doesn't stop retrieving results prematurely. Fixes googleapis#386
googlebot
added
the
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some queries, when paging through batches of results, Firestore will
return a batch that has no results, even though there are still results
left to return for the query. Previously, this would cause
QueryIteratorto prematurely stop iterating over results. Emptybatches are now handled and skipped so that
QueryIteratordoesn't stopretrieving results prematurely.
Fixes #386