feat: add namespace property to context.Context#388
Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom Apr 15, 2020
Merged
feat: add namespace property to context.Context#388chrisrossi merged 1 commit intogoogleapis:masterfrom
namespace property to context.Context#388chrisrossi merged 1 commit intogoogleapis:masterfrom
Conversation
It is now possible to set the namespace on the context, overriding the
namespace set on the client. This makes it easier to write multi-homed
applications which might access different namespaces depending on which
user is logged in or other variable only known at request time.
`client.Client.context` has a new argument, `namespace`, which can be
used to set the namespace at request time. Here is an example of you
might do this in a WSGI middleware:
~~~~
def ndb_wsgi_middleware(wsgi_app):
client = ndb.Client()
def middleware(environ, start_response):
global_cache = ndb.RedisCache.from_environment()
namespace = get_namespace_from_request(environ)
with client.context(global_cache=global_cache, namespace=namespace):
return wsgi_app(environ, start_response)
return middleware
app = flask.Flask("NDB Example")
app.wsgi_app = ndb_wsgi_middleware(app.wsgi_app) # Wrap the app in middleware.
~~~~
Closes googleapis#385.
cguardia
approved these changes
Apr 14, 2020
Contributor
cguardia
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now possible to set the namespace on the context, overriding the
namespace set on the client. This makes it easier to write multi-homed
applications which might access different namespaces depending on which
user is logged in or other variable only known at request time.
client.Client.contexthas a new argument,namespace, which can beused to set the namespace at request time. Here is an example of you
might do this in a WSGI middleware:
Closes #385.