Skip to content

fix: allow legacy ndb to read LocalStructuredProperty entities.#344

Merged
cguardia merged 2 commits intogoogleapis:masterfrom
cguardia:repeated-local-structured-property
Feb 24, 2020
Merged

fix: allow legacy ndb to read LocalStructuredProperty entities.#344
cguardia merged 2 commits intogoogleapis:masterfrom
cguardia:repeated-local-structured-property

Conversation

@cguardia
Copy link
Contributor

Legacy ndb is not able to read back serialized entities when using repeated LocalStructuredProperty. This fix saves those entities without serialization when legacy data is set in the context (default behavior)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2020
@cguardia cguardia force-pushed the repeated-local-structured-property branch from 0c0ae17 to 0300ab3 Compare February 24, 2020 05:35
@cguardia cguardia requested a review from chrisrossi February 24, 2020 05:51
@cguardia cguardia force-pushed the repeated-local-structured-property branch from 27c431e to 9fa96e9 Compare February 24, 2020 18:15
@cguardia cguardia added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Legacy ndb is not able to read back serialized entities when using repeated LocalStructuredProperty.
@cguardia cguardia force-pushed the repeated-local-structured-property branch from 5787ce1 to 62114a3 Compare February 24, 2020 19:46
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
A single typo was cut and pasted into multiple places.
@cguardia cguardia merged commit 7b07692 into googleapis:master Feb 24, 2020
@zyzniewski
Copy link
Contributor

does it take keep_keys=True into account?

@zyzniewski
Copy link
Contributor

#355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants