Skip to content

fix: make sure key.Key uses namespace from client when not specified#339

Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom
chrisrossi:fix-337
Feb 18, 2020
Merged

fix: make sure key.Key uses namespace from client when not specified#339
chrisrossi merged 1 commit intogoogleapis:masterfrom
chrisrossi:fix-337

Conversation

@chrisrossi
Copy link
Contributor

Fixes #337

@chrisrossi chrisrossi requested a review from cguardia February 18, 2020 19:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2020
Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chrisrossi chrisrossi merged commit 44f02e4 into googleapis:master Feb 18, 2020
@chrisrossi chrisrossi deleted the fix-337 branch February 18, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace is not set from Client if Model is set id.

3 participants