fix: disuse __slots__ in most places#330
Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom Feb 11, 2020
Merged
Conversation
In Python 2.7, classes which use `__slots__` can't be pickled. Users have reported problems trying to pickle NDB entities, indicating there is some perceived use case for pickling entities. Fixes googleapis#311
googlebot
added
the
cla: yes
Contributor
Author
|
Kokoro had a transient error related to intersphinx: |
chrisrossi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 2.7, classes which use
__slots__can't be pickled. Usershave reported problems trying to pickle NDB entities, indicating there
is some perceived use case for pickling entities.
Fixes #311