googleapis · arithmetic1728 · Oct 6, 2020 · Sep 30, 2020 · Oct 5, 2020 · Oct 6, 2020
diff --git a/.coveragerc b/.coveragerc
@@ -23,16 +23,14 @@ omit =
 [report]
 fail_under = 100
 show_missing = True
+omit = google/cloud/monitoring/__init__.py
 exclude_lines =
     # Re-enable the standard pragma
     pragma: NO COVER
     # Ignore debug-only repr
     def __repr__
-    # Ignore abstract methods
-    raise NotImplementedError
-omit =
-  */gapic/*.py
-  */proto/*.py
-  */core/*.py
-  */site-packages/*.py
-  google/cloud/__init__.py
+    # Ignore pkg_resources exceptions.
+    # This is added at the module level as a safeguard for if someone
+    # generates the code and tries to run it without pip installing. This
+    # makes it virtually impossible to test properly.
+    except pkg_resources.DistributionNotFound
diff --git a/.kokoro/samples/python3.6/common.cfg b/.kokoro/samples/python3.6/common.cfg
@@ -13,6 +13,12 @@ env_vars: {
     value: "py-3.6"
 }
 
+# Declare build specific Cloud project.
+env_vars: {
+    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
+    value: "python-docs-samples-tests-py36"
+}
+
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
     value: "github/python-monitoring/.kokoro/test-samples.sh"
@@ -24,12 +30,6 @@ env_vars: {
     value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker"
 }
 
-# Declare build specific Cloud project.
-env_vars: {
-    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
-    value: "python-docs-samples-tests-py36"
-}
-
 # Download secrets for samples
 gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples"
 

diff --git a/.kokoro/samples/python3.7/common.cfg b/.kokoro/samples/python3.7/common.cfg
@@ -13,6 +13,12 @@ env_vars: {
     value: "py-3.7"
 }
 
+# Declare build specific Cloud project.
+env_vars: {
+    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
+    value: "python-docs-samples-tests-py37"
+}
+
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
     value: "github/python-monitoring/.kokoro/test-samples.sh"
@@ -24,12 +30,6 @@ env_vars: {
     value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker"
 }
 
-# Declare build specific Cloud project.
-env_vars: {
-    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
-    value: "python-docs-samples-tests-py37"
-}
-
 # Download secrets for samples
 gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples"
 

diff --git a/.kokoro/samples/python3.8/common.cfg b/.kokoro/samples/python3.8/common.cfg
@@ -13,6 +13,12 @@ env_vars: {
     value: "py-3.8"
 }
 
+# Declare build specific Cloud project.
+env_vars: {
+    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
+    value: "python-docs-samples-tests-py38"
+}
+
 env_vars: {
     key: "TRAMPOLINE_BUILD_FILE"
     value: "github/python-monitoring/.kokoro/test-samples.sh"
@@ -24,12 +30,6 @@ env_vars: {
     value: "gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker"
 }
 
-# Declare build specific Cloud project.
-env_vars: {
-    key: "BUILD_SPECIFIC_GCLOUD_PROJECT"
-    value: "python-docs-samples-tests-py38"
-}
-
 # Download secrets for samples
 gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/python-docs-samples"
 

diff --git a/README.rst b/README.rst
@@ -51,11 +51,13 @@ dependencies.
 
 Supported Python Versions
 ^^^^^^^^^^^^^^^^^^^^^^^^^
-Python >= 3.5
+Python >= 3.6
 
-Deprecated Python Versions
-^^^^^^^^^^^^^^^^^^^^^^^^^^
-Python == 2.7. Python 2.7 support will be removed on January 1, 2020.
+Unsupported Python Versions
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+Python == 2.7.
+
+The last version of this library compatible with Python 2.7 is google-cloud-monitoring==1.1.0.
 
 
 Mac/Linux

diff --git a/UPGRADING.md b/UPGRADING.md
@@ -0,0 +1,159 @@
+# 2.0.0 Migration Guide
+
+The 2.0 release of the `google-cloud-monitoring` client is a significant upgrade based on a [next-gen code generator](https://github.com/googleapis/gapic-generator-python), and includes substantial interface changes. Existing code written for earlier versions of this library will likely require updates to use this version. This document describes the changes that have been made, and what you need to do to update your usage.
+
+If you experience issues or have questions, please file an [issue](https://github.com/googleapis/python-monitoring/issues).
+
+## Supported Python Versions
+
+> **WARNING**: Breaking change
+
+The 2.0.0 release requires Python 3.6+.
+
+
+## Method Calls
+
+> **WARNING**: Breaking change
+
+Methods expect request objects. We provide a script that will convert most common use cases.
+
+* Install the library
+
+```py
+python3 -m pip install google-cloud-monitoring
+```
+
+* The script `fixup_monitoring_v3_keywords.py` is shipped with the library. It expects
+an input directory (with the code to convert) and an empty destination directory.
+
+```sh
+$ fixup_monitoring_v3_keywords.py --input-directory .samples/ --output-directory samples/
+```
+
+**Before:**
+```py
+from google.cloud import monitoring_v3
+
+client = monitoring_v3.MetricServiceClient()
+
+metric_descriptor = client.get_metric_descriptor("name")
+```
+
+
+**After:**
+```py
+from google.cloud import monitoring_v3
+
+client = monitoring_v3.MetricServiceClient()
+
+metric_descriptor = client.get_metric_descriptor(request={"name": "name"})
+```
+
+### More Details
+
+In `google-cloud-monitoring<2.0.0`, parameters required by the API were positional parameters and optional parameters were keyword parameters.
+
+**Before:**
+```py
+    def create_metric_descriptor(
+        self,
+        name,
+        metric_descriptor,
+        retry=google.api_core.gapic_v1.method.DEFAULT,
+        timeout=google.api_core.gapic_v1.method.DEFAULT,
+        metadata=None,
+    ):
+```
+
+In the 2.0.0 release, all methods have a single positional parameter `request`. Method docstrings indicate whether a parameter is required or optional.
+
+Some methods have additional keyword only parameters. The available parameters depend on the `google.api.method_signature` annotation specified by the API producer.
+
+
+**After:**
+```py
+    def create_metric_descriptor(
+        self,
+        request: metric_service.CreateMetricDescriptorRequest = None,
+        *,
+        name: str = None,
+        metric_descriptor: ga_metric.MetricDescriptor = None,
+        retry: retries.Retry = gapic_v1.method.DEFAULT,
+        timeout: float = None,
+        metadata: Sequence[Tuple[str, str]] = (),
+    ) -> ga_metric.MetricDescriptor:
+```
+
+> **NOTE:** The `request` parameter and flattened keyword parameters for the API are mutually exclusive.
+> Passing both will result in an error.
+
+
+Both of these calls are valid:
+
+```py
+response = client.create_metric_descriptor(
+    request={
+        "name": name,
+        "metric_descriptor": metric_descriptor
+    }
+)
+```
+
+```py
+response = client.create_metric_descriptor(
+    name=name,
+    metric_descriptor=metric_descriptor
+)
+```
+
+This call is invalid because it mixes `request` with a keyword argument `metric_descriptor`. Executing this code
+will result in an error.
+
+```py
+response = client.create_metric_descriptor(
+    request={
+        "name": name,
+    },
+    metric_descriptor=metric_descriptor
+)
+```
+
+
+
+## Enums and Types
+
+
+> **WARNING**: Breaking change
+
+The submodules `enums` and `types` have been removed.
+
+**Before:**
+```py
+from google.cloud import monitoring_v3
+
+launch_stage = monitoring_v3.enums.LaunchStage.ALPHA
+policy = monitoring_v3.types.AlertPolicy(name="name")
+```
+
+
+**After:**
+```py
+from google.cloud import monitoring_v3
+
+launch_stage = monitoring_v3.LaunchStage.ALPHA
+policy = monitoring_v3.AlertPolicy(name="name")
+```
+
+## Project Path Helper Method
+
+`project_path` method is renamed `common_project_path`.
+
+**Before:**
+```py
+project_path = client.project_path("project_id")
+```
+
+**After:**
+```py
+project_path = client.common_project_path("project_id")
+```
diff --git a/docs/UPGRADING.md b/docs/UPGRADING.md
@@ -0,0 +1 @@
+../UPGRADING.md
diff --git a/docs/gapic/v3/api.rst b/docs/gapic/v3/api.rst
diff --git a/docs/gapic/v3/types.rst b/docs/gapic/v3/types.rst
diff --git a/docs/index.rst b/docs/index.rst
@@ -8,8 +8,18 @@ Api Reference
     :maxdepth: 2
 
     query.rst
-    gapic/v3/api
-    gapic/v3/types
+    monitoring_v3/services
+    monitoring_v3/types
+
+Migration Guide
+---------------
+
+See the guide below for instructions on migrating to the 2.x release of this library.
+
+.. toctree::
+    :maxdepth: 2
+
+    UPGRADING
 
 Changelog
 ---------

diff --git a/docs/monitoring_v3/services.rst b/docs/monitoring_v3/services.rst
@@ -0,0 +1,21 @@
+Services for Google Cloud Monitoring v3 API
+===========================================
+
+.. automodule:: google.cloud.monitoring_v3.services.alert_policy_service
+    :members:
+    :inherited-members:
+.. automodule:: google.cloud.monitoring_v3.services.group_service
+    :members:
+    :inherited-members:
+.. automodule:: google.cloud.monitoring_v3.services.metric_service
+    :members:
+    :inherited-members:
+.. automodule:: google.cloud.monitoring_v3.services.notification_channel_service
+    :members:
+    :inherited-members:
+.. automodule:: google.cloud.monitoring_v3.services.service_monitoring_service
+    :members:
+    :inherited-members:
+.. automodule:: google.cloud.monitoring_v3.services.uptime_check_service
+    :members:
+    :inherited-members:
diff --git a/docs/monitoring_v3/types.rst b/docs/monitoring_v3/types.rst
@@ -0,0 +1,5 @@
+Types for Google Cloud Monitoring v3 API
+========================================
+
+.. automodule:: google.cloud.monitoring_v3.types
+    :members:
diff --git a/google/cloud/monitoring.py b/google/cloud/monitoring.py