Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structured log adapter #751

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: structured log adapter #751

wants to merge 3 commits into from

Conversation

NewGlad
Copy link

@NewGlad NewGlad commented May 25, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) Do I need to update docs?

Fixes #750 🦕

@NewGlad NewGlad requested review from a team as code owners May 25, 2023 07:11
@google-cla
Copy link

google-cla bot commented May 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 25, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented May 25, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label May 25, 2023
@NewGlad
Copy link
Author

NewGlad commented May 25, 2023

@daniel-sanche could you help, is there a way to run tests and linter in GitHub actions for my changes?

@NewGlad NewGlad force-pushed the main branch 2 times, most recently from fe4e4f7 to 79c24f8 Compare May 25, 2023 08:08
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jun 24, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Jul 24, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2023
@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@daniel-sanche daniel-sanche changed the title Add AppendLabelLoggingAdapter to have an ability to adapt logger with… feat: structured log adapter Sep 25, 2023
@NewGlad
Copy link
Author

NewGlad commented Oct 10, 2023

@daniel-sanche
Any chance of getting a review for this PR?

@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add StructuredLogHandler adapter
5 participants