New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exception log message format #394
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e67822a
added a test to catch exception parsing
daniel-sanche ed7492a
fixed behaviour
daniel-sanche 207833b
added environment test
daniel-sanche 124783e
🦉 Updates from OwlBot
gcf-owl-bot[bot] 30362d2
submodule update
daniel-sanche 2153e27
updated to be more inline with logging stdlib
daniel-sanche 5337252
Merge branch 'parse-exceptions' of github.com:googleapis/python-loggi…
daniel-sanche cd2b678
🦉 Updates from OwlBot
gcf-owl-bot[bot] 4af920a
updated submodule
daniel-sanche 3de511c
Merge branch 'parse-exceptions' of github.com:googleapis/python-loggi…
daniel-sanche 707c5a8
update submodule
daniel-sanche b4ab4cc
added comment
daniel-sanche 18b8211
udated submodule
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule environment
updated
2 files
+5 −0 | deployable/python/snippets.py | |
+7 −0 | tests/common/python.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the record object is used for logging, what is a reason to create a full copy of the record object? why not to reset the .exc_info on the argument directly?
Otherwise, consider to use a distinct variable for the copy instead of "reusing"
record
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing some experimenting, but ended up modifying the record object directly