Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove noisy logs #290

Merged
merged 6 commits into from May 11, 2021
Merged

fix: remove noisy logs #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b34eaba
added owlbot to gitignore
daniel-sanche May 6, 2021
95da8eb
add to excluded logger list
daniel-sanche May 10, 2021
7b08acb
updated environment tests
daniel-sanche May 10, 2021
d39fd40
added comments
daniel-sanche May 10, 2021
425e479
fix lint issue
daniel-sanche May 10, 2021
3848c19
fixed unit test
daniel-sanche May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -61,3 +61,6 @@ system_tests/local_test_setup
# Make sure a generated file isn't accidentally committed.
pylintrc
pylintrc.test

# ignore owlbot
owl-bot-staging
11 changes: 9 additions & 2 deletions google/cloud/logging_v2/handlers/handlers.py
View file
Open in desktop
Expand Up @@ -24,7 +24,14 @@

DEFAULT_LOGGER_NAME = "python"

EXCLUDED_LOGGER_DEFAULTS = ("google.cloud", "google.auth", "google_auth_httplib2")
"""Exclude internal logs from propagating through handlers"""
EXCLUDED_LOGGER_DEFAULTS = (
"google.cloud",
"google.auth",
"google_auth_httplib2",
"google.api_core.bidi",
"werkzeug",
)

_CLEAR_HANDLER_RESOURCE_TYPES = ("gae_app", "cloud_function")

Expand Down Expand Up @@ -221,6 +228,6 @@ def setup_logging(
logger.setLevel(log_level)
logger.addHandler(handler)
for logger_name in all_excluded_loggers:
# prevent excluded loggers from propagating logs to handler
logger = logging.getLogger(logger_name)
logger.propagate = False
logger.addHandler(logging.StreamHandler())
2 changes: 1 addition & 1 deletion tests/environment
Open in desktop
Submodule environment updated 1 files
+20 −0 deployable/python/snippets.py
16 changes: 14 additions & 2 deletions tests/unit/test_client.py
View file
Open in desktop
Expand Up @@ -799,7 +799,13 @@ def test_setup_logging(self):
handler.transport.worker.stop()

expected_kwargs = {
"excluded_loggers": ("google.cloud", "google.auth", "google_auth_httplib2"),
"excluded_loggers": (
"google.cloud",
"google.auth",
"google_auth_httplib2",
"google.api_core.bidi",
"werkzeug",
),
"log_level": 20,
}
self.assertEqual(kwargs, expected_kwargs)
Expand Down Expand Up @@ -836,7 +842,13 @@ def test_setup_logging_w_extra_kwargs(self):
handler.transport.worker.stop()

expected_kwargs = {
"excluded_loggers": ("google.cloud", "google.auth", "google_auth_httplib2"),
"excluded_loggers": (
"google.cloud",
"google.auth",
"google_auth_httplib2",
"google.api_core.bidi",
"werkzeug",
),
"log_level": 20,
}
self.assertEqual(kwargs, expected_kwargs)
Expand Down