New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom labels with standard library logging #264
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1714f44
improved source location handling
daniel-sanche 5edf4e4
improved some tests
daniel-sanche d357032
all handlers send source location
daniel-sanche 490d455
fixed missing ,
daniel-sanche 9e173fd
fixed issues with unit tests
daniel-sanche 21279a9
fixed lint issues
daniel-sanche 556ecd8
updated environment tests
daniel-sanche 3dccd1a
add log filter to CloudLoggingHandler
daniel-sanche 7842536
updated tests
daniel-sanche 125ae82
Merge branch 'v2_update_2' into improve-source-location
daniel-sanche 1b4e7ff
improved label handling
daniel-sanche b084cd9
fixed tests
daniel-sanche 5e1f22b
added better comment
daniel-sanche 0d5e4bb
Merge branch 'improve-source-location' into override_labels
daniel-sanche 78f8ca2
added new environment test
daniel-sanche 790d19a
Merge branch 'v2_update_2' into override_labels
daniel-sanche f19c33e
fixed broken test
daniel-sanche 99b4f58
fixed labels on structured logging handler
daniel-sanche 0baa60a
fixed lint
daniel-sanche 54ff4bc
fixed unit tests
daniel-sanche 09fcf6b
updated environment tests
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule environment
updated
6 files
+26 −6 | deployable/python/snippets.py | |
+3 −1 | tests/common/common.py | |
+71 −45 | tests/common/python.py | |
+12 −11 | tests/nodejs/test_cloudrun.py | |
+6 −6 | tests/python/test_cloudrun.py | |
+7 −6 | tests/python/test_functions.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of curiosity, would this work if users provided nested labels? actually, do we/do we not allow nested labels?