Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove keyword only argument for RequestsMiddleware #113

Merged
merged 3 commits into from Dec 7, 2020
Merged

fix: Remove keyword only argument for RequestsMiddleware #113

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f0d441
fix: Remove keyword only argument for RequestsMiddleware
bradykieffer Dec 3, 2020
048de83
Test that we can instantiate middleware with or without kwargs
bradykieffer Dec 4, 2020
17811e8
Make get_response a required parameter in RequestMiddleware
bradykieffer Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/logging_v2/handlers/middleware/request.py
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@ def _get_django_request():
class RequestMiddleware(MiddlewareMixin):
"""Saves the request in thread local"""

def __init__(self, *, get_response=None):
def __init__(self, get_response=None):
self.get_response = get_response

def process_request(self, request):
Expand Down