feat: allow custom labels with standard library logging #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
changed the title
0xSage
reviewed
Apr 22, 2021
| user_labels = getattr(record, "labels", {}) | ||
| record.total_labels = {**self.default_labels, **user_labels} | ||
| record.total_labels_str = ", ".join( | ||
| [f'"{k}": "{v}"' for k, v in record.total_labels.items()] |
There was a problem hiding this comment.
just out of curiosity, would this work if users provided nested labels? actually, do we/do we not allow nested labels?
0xSage
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library now fully supports passing in extra labels when logging though the standard library
I also added a number of unit and environment tests around this new functionality