refactor: modify codes as review suggests

googleapis · Mar 6, 2021 · 93be238 · 93be238
1 parent ae0fca5
commit 93be238
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/google/cloud/logging_v2/handlers/_helpers.py b/google/cloud/logging_v2/handlers/_helpers.py
@@ -33,7 +33,7 @@
 _PROTOCOL_HEADER = "SERVER_PROTOCOL"
 
 
-def format_stackdriver_json(record, message, json_ensure_ascii):
+def format_stackdriver_json(record, message):
     """Helper to format a LogRecord in in Stackdriver fluentd format.
 
     Returns:
@@ -48,7 +48,7 @@ def format_stackdriver_json(record, message, json_ensure_ascii):
         "severity": record.levelname,
     }
 
-    return json.dumps(payload, ensure_ascii=json_ensure_ascii)
+    return json.dumps(payload, ensure_ascii=False)
 
 
 def get_request_data_from_flask():

diff --git a/google/cloud/logging_v2/handlers/container_engine.py b/google/cloud/logging_v2/handlers/container_engine.py
@@ -31,7 +31,7 @@ class ContainerEngineHandler(logging.StreamHandler):
     (GKE) fluentd plugin, so that metadata such as log level are properly set.
     """
 
-    def __init__(self, *, name=None, stream=None, json_ensure_ascii=True):
+    def __init__(self, *, name=None, stream=None):
         """
         Args:
             name (Optional[str]): The name of the custom log in Cloud Logging.
@@ -40,7 +40,6 @@ def __init__(self, *, name=None, stream=None, json_ensure_ascii=True):
         """
         super(ContainerEngineHandler, self).__init__(stream=stream)
         self.name = name
-        self.json_ensure_ascii = json_ensure_ascii
 
     def format(self, record):
         """Format the message into JSON expected by fluentd.
@@ -52,4 +51,4 @@ def format(self, record):
             str: A JSON string formatted for GKE fluentd.
         """
         message = super(ContainerEngineHandler, self).format(record)
-        return format_stackdriver_json(record, message, self.json_ensure_ascii)
+        return format_stackdriver_json(record, message)