Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix: resolve issue importing library #64

Merged
merged 4 commits into from Aug 20, 2021
Merged

fix: resolve issue importing library #64

merged 4 commits into from Aug 20, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 16, 2021

Fixes #63 馃

@parthea parthea requested a review from a team as a code owner August 16, 2021 11:38
@product-auto-label product-auto-label bot added the api: gkehub Issues related to the googleapis/python-gke-hub API. label Aug 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2021
@parthea parthea mentioned this pull request Aug 16, 2021
Closed
tseaver
tseaver suggested changes Aug 16, 2021
View reviewed changes
docs/gkehub_v1/configmanagement_v1/types.rst Show resolved Hide resolved
google/cloud/gkehub_v1/types/feature.py Outdated Show resolved Hide resolved
owlbot.py Outdated Show resolved Hide resolved
owlbot.py Show resolved Hide resolved
owlbot.py Show resolved Hide resolved
@tseaver tseaver mentioned this pull request Aug 16, 2021
Merged
@busunkim96
Copy link
Contributor

configmanagement and multiclusteringress to live under the gogole/cloud/gkehub/v1 in the protos so this seems like the right thing to do.

busunkim96
busunkim96 suggested changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configmanagement and multiclusteringress live under the google/cloud/gkehub/v1 in the protos so this new namespacing seems correct. Leaving the types here also SGTM, since the protos are clearly nested under a specific version of gkehub.

However, I believe we agreed on generating library types through proto-plus (like python-access-approval). In the event either of these sub packages turns into its own GAPIC (which does look pretty unlikely in this case) the change will be non-breaking. IMO the library types being consistently proto-plus also provides a better end user experience.

For more discussion on a similar issue, see googleapis/python-access-context-manager#42.

owlbot.py Show resolved Hide resolved
@parthea
Copy link
Contributor Author

parthea commented Aug 20, 2021

@busunkim96 Please could you review/approve?

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit cfa166e into master Aug 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-dependency-import branch August 20, 2021 18:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 23, 2021
@release-please
chore: release 0.2.1 (#66)
9e928a1 
馃 I have created a release \*beep\* \*boop\*
---
### [0.2.1](https://www.github.com/googleapis/python-gke-hub/compare/v0.2.0...v0.2.1) (2021-08-20)


### Bug Fixes

* resolve issue importing library ([#64](https://www.github.com/googleapis/python-gke-hub/issues/64)) ([cfa166e](https://www.github.com/googleapis/python-gke-hub/commit/cfa166e9b9024920bd00b5994d2638ab7716c2d1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tseaver tseaver tseaver approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
api: gkehub Issues related to the googleapis/python-gke-hub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot import name 'GkeHubClient'
3 participants
@parthea @busunkim96 @tseaver