Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create base transaction class #81

Merged
merged 2 commits into from Jul 14, 2020
Merged

refactor: create base transaction class #81

merged 2 commits into from Jul 14, 2020

Conversation

rafilong
Copy link
Contributor

@rafilong rafilong commented Jul 6, 2020

towards #65

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2020
@rafilong rafilong changed the base branch from master to v2-staging July 6, 2020 23:05
@rafilong rafilong mentioned this pull request Jul 6, 2020
Merged
BenWhitehead
BenWhitehead approved these changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems inline with what we've been talking about. Deferring to @crwilcox for code specifics.

@crwilcox
Copy link
Contributor

This lgtm. Let's hold though until the big merge in #91

@rafilong rafilong added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 546eb90 into googleapis:v2-staging Jul 14, 2020
@rafilong rafilong deleted the refactor-transaction branch July 22, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafilong @crwilcox @BenWhitehead @googlebot