Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.1.2 #361

Merged
merged 1 commit into from Jun 14, 2021
Merged

chore: release 2.1.2 #361

merged 1 commit into from Jun 14, 2021

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented May 24, 2021

馃 I have created a release *beep* *boop*

2.1.2 (2021-06-14)

Documentation

  • fix broken links in multiprocessing.rst (#360) (6e2c899)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team May 24, 2021 16:32
@release-please release-please bot requested a review from a team as a code owner May 24, 2021 16:32
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label May 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2021
@tseaver tseaver merged commit bc90ff8 into master Jun 14, 2021
@tseaver tseaver deleted the release-v2.1.2 branch June 14, 2021 20:04
@yoshi-automation
Copy link
Contributor

@release-tool-publish-reporter

The release build has started, the log can be viewed here. 馃尰

@release-tool-publish-reporter

馃 You hatched a release! The release build finished successfully! 馃挏

@EDjur
Copy link

EDjur commented Jun 15, 2021

Hi there! Looks like this perhaps broke something? @tseaver

  File "....python3.6/site-packages/google/cloud/firestore_v1/services/firestore/transports/base.py", line 18, in <module>
    import packaging.version
ModuleNotFoundError: No module named 'packaging'

on startup of our container.

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2021

@EDjur I have opened #371 to track this issue.

@parthea, @busunkim96 packaging cannot be imported by default, and it isn't a dependency for firestore. I'm not sure why CI was passing for #365, but we need to be lots more careful when applying the "blanket" changes to the manual libraries.

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2021

@EDjur Out of curiousity, how are you installing google-cloud-firestore in your environment? Our CI passes because we use nox to run tests, which sits on top of the venv module and pip, and therefore gets packaging installed by default.

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2021

@EDjur The fix for #371 should be rolled out shortly in the upcoming 2.1.3 release.

@EDjur
Copy link

EDjur commented Jun 16, 2021

Let's see here.... we use venv together with pip and then install and run tox in that environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants