Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use an insecure channel under emulation #254

Merged
merged 8 commits into from Nov 12, 2020
Merged

fix: use an insecure channel under emulation #254

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
674b838
fix: use an insecure channel under emulation
crwilcox Nov 12, 2020
d176c1d
Merge branch 'master' into insecure-channel
crwilcox Nov 12, 2020
05bc809
test: modify test mock to use grpc.insecure_channel
crwilcox Nov 12, 2020
23f2a8e
test: noticed setup lint wasn't running, downgrade default python
crwilcox Nov 12, 2020
0a05f19
Merge branch 'insecure-channel' of github.com:googleapis/python-fires…
crwilcox Nov 12, 2020
c915e76
chore: lint
crwilcox Nov 12, 2020
c5c3636
chore: pytype
crwilcox Nov 12, 2020
9824d38
test: use 3.8 for system tests for now
crwilcox Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions google/cloud/firestore_v1/base_client.py
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@
"""

import os
import grpc

import google.api_core.client_options # type: ignore
import google.api_core.path_template # type: ignore
Expand Down Expand Up @@ -147,9 +148,7 @@ def _firestore_api_helper(self, transport, client_class, client_module) -> Any:
# We need this in order to set appropriate keepalive options.

if self._emulator_host is not None:
# TODO(microgen): this likely needs to be adapted to use insecure_channel
# on new generated surface.
channel = transport.create_channel(host=self._emulator_host)
channel = grpc.insecure_channel(self._emulator_host)
else:
channel = transport.create_channel(
self._target,
Expand Down