New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retry/timeout to manual surface #222
Merged
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8d03921
feat: add retry/timeout to 'client.Client.get_all'
tseaver e7d2119
feat: add retry/timeout to 'client.Client.collections'
tseaver 6bfe32f
feat: add retry/timeout to 'batch.Batch.commit'
tseaver 6ba6d21
feat: add retry/timeout to 'document.DocumentReference.get'
tseaver e6ad4a1
feat: add retry/timeout to 'query.Query.get'
tseaver 6e806b0
feat: add retry/timeout to 'query.CollectionGroup.get_partitions'
tseaver 00736fe
feat: add retry/timeout to 'collection.CollectionReference.add'
tseaver 2b80b91
feat: add retry/timeout to 'collection.CollectionReference.list_docum…
tseaver 49d3b03
feat: add retry/timeout to 'collection.CollectionReference.get'
tseaver 16a1e34
feat: add retry/timeout to 'collection.CollectionReference.stream'
tseaver a9547e6
feat: add retry/timeout to 'document.DocumentReference.collections'
tseaver d6df19c
feat: add retry/timeout to 'document.DocumentReference.delete'
tseaver 6eae0e7
feat: add retry/timeout to 'document.DocumentReference.create'
tseaver 559f2eb
feat: add retry/timeout to 'document.DocumentReference.set'
tseaver 8038cce
feat: add retry/timeout to 'document.DocumentReference.update'
tseaver 2d413df
feat: add retry/timeout to 'query.Query.stream'
tseaver e15b8f6
feat: add retry/timeout to 'transaction.Transaction.get_all'
tseaver 9f5bbb4
feat: add retry/timeout to 'transaction.Transaction.get'
tseaver 5a1ef50
feat: add retry/timeout to base class signatures
tseaver 6dec6f3
fix: un-break docs build
tseaver 812c41f
chore: factor out helper for computing retry / timeout kwargs
tseaver 8c67138
chore: factor out common prep for 'collections'/'get_all' to base class
tseaver bad75e1
chore: factor out test helper for 'collections'
tseaver db01b59
feat: add retry/timeout to 'async_client.AsyncClient.{collections.get…
tseaver 4090a00
chore: use factored-out helper to build retry/timeout kwargs
tseaver 40fae96
chore: clean up tests for 'client.Client.get_all'
tseaver df615e4
chore: lint
tseaver a557a15
feat: add retry/timeout to 'async_batch.AsyncBatch.commit'
tseaver 4e3be50
feat: add retry/timeout to 'async_document.AsyncDocument` methods
tseaver ec8002c
feat: add retry/timeout to 'async_query.Async{Query,CollectionGroup}'
tseaver c81cd8c
feat: add retry/timeout to 'async_collection.AsyncCollectionReference'
tseaver 1acbde3
fix: typo
tseaver b998db2
chore: rename testcases/helper for clarity
tseaver 46f27e6
feat: add retry/timeout to 'async_transaction.AsyncTransaction' methods
tseaver 9b4707a
fix: typo
tseaver 7a976a5
chore: appease pytype
tseaver 4b1ec26
fix: actually test retry / timeout
tseaver c5e4056
fix: document system-specified defaults for 'retry' / 'timeout'
tseaver 2360eac
fix: use gapic's 'DEFAULT' sentinel for 'retry'
tseaver f15a523
Merge branch 'master' into 221-retry-timeout
tseaver 3feb63b
chore: lint
tseaver File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad75e1 factors out the redundancy in the tests for
Client.collections
.