Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: allow running systests on emulator #168

Merged
merged 5 commits into from Sep 16, 2020
Merged

tests: allow running systests on emulator #168

merged 5 commits into from Sep 16, 2020

Conversation

HemangChothani
Copy link
Contributor

To satisfy the comment on PR #31 (comment)

  • The system tests are failing against the emulator due to this TODO:

python-firestore/google/cloud/firestore_v1/base_client.py

Lines 147 to 150 in a22ecdd

if self._emulator_host is not None:
# TODO(microgen): this likely needs to be adapted to use insecure_channel
# on new generated surface.
channel = transport.create_channel(host=self._emulator_host)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 21, 2020
@HemangChothani HemangChothani changed the title feat: add support of emulator to run system tests on emulato feat: add support of emulator to run system tests on emulator Aug 21, 2020
@tseaver tseaver changed the base branch from v2-staging to master August 27, 2020 15:15
@tseaver tseaver changed the base branch from master to v2-staging August 27, 2020 15:15
tseaver
tseaver suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HemangChothani Please rebase / retarget your changes against the current master branch. The v2-staging branch is no longer active (@crwilcox force-pushed it to master last week).

@HemangChothani HemangChothani changed the base branch from v2-staging to master August 28, 2020 07:56
tseaver
tseaver suggested changes Sep 1, 2020
View reviewed changes
tests/system/test_system.py Outdated Show resolved Hide resolved
tests/system/test_system_async.py Outdated Show resolved Hide resolved
@HemangChothani
Copy link
Contributor Author

@tseaver PTAL

@tseaver tseaver changed the title feat: add support of emulator to run system tests on emulator tests: allow running systests on emulator Sep 16, 2020
@tseaver tseaver merged commit 3987846 into googleapis:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HemangChothani @tseaver