Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add inline type hints #134

Merged
merged 27 commits into from Aug 6, 2020
Merged

feat: add inline type hints #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e31f7ba
feat: add type hits via pytype
crwilcox Jul 28, 2020
4fc72b7
process: run merge-pyi on some, manual corrections
crwilcox Jul 28, 2020
6a05227
process: run merge-pyi on some, manual corrections
crwilcox Jul 29, 2020
067a0d0
process: run merge-pyi on some, manual corrections
crwilcox Jul 29, 2020
57b88b3
fix: blacken
crwilcox Jul 29, 2020
697217f
docs: link to bug for pytype coroutine/union
crwilcox Jul 29, 2020
903b856
Merge branch 'v2-staging' into pytype
crwilcox Jul 31, 2020
44bd59c
fix: modify union coroutine types
crwilcox Jul 31, 2020
bcfd00c
fix: changes after merge
crwilcox Jul 31, 2020
50e6af7
fix: blacken
crwilcox Jul 31, 2020
b902bac
fix: narrow types, remove unused imports
crwilcox Aug 4, 2020
fb2cf23
fix: remove duplication
crwilcox Aug 4, 2020
f0ffd5a
fix: remove unnecessary union
crwilcox Aug 4, 2020
c07957a
fix: feedback
crwilcox Aug 4, 2020
bf2dbd8
fix: some import modifications
crwilcox Aug 4, 2020
fd7305d
fix: some import modifications
crwilcox Aug 4, 2020
85f1cc6
use 3.7 as 3.8 is instable for pytype
crwilcox Aug 4, 2020
c31bf2d
ignore other module types
crwilcox Aug 5, 2020
f1d3904
ignore other module types
crwilcox Aug 5, 2020
b509c72
ignore other module types
crwilcox Aug 5, 2020
67d828d
ignore other module types
crwilcox Aug 5, 2020
0d6cf2b
ignore other module types
crwilcox Aug 5, 2020
8f92945
ignore other module types
crwilcox Aug 5, 2020
e3c295d
ignore other module types
crwilcox Aug 5, 2020
6c3052e
ignore other module types
crwilcox Aug 5, 2020
cdec8ec
ignore other module types
crwilcox Aug 6, 2020
edf3c64
remove duplicate declarations
crwilcox Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions google/cloud/firestore.py
View file
Open in desktop
Expand Up @@ -46,6 +46,10 @@
from google.cloud.firestore_v1 import Watch
from google.cloud.firestore_v1 import WriteBatch
from google.cloud.firestore_v1 import WriteOption
from typing import List

__all__: List[str]
__version__: str


__all__ = [
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@
from google.auth import credentials # type: ignore
from google.oauth2 import service_account # type: ignore

from google.api_core import operation as ga_operation
from google.api_core import operation_async
from google.api_core import operation as ga_operation # type: ignore
from google.api_core import operation_async # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogen code: how are we going to preserve this work?

from google.cloud.firestore_admin_v1.services.firestore_admin import pagers
from google.cloud.firestore_admin_v1.types import field
from google.cloud.firestore_admin_v1.types import field as gfa_field
Expand Down
6 changes: 3 additions & 3 deletions google/cloud/firestore_admin_v1/services/firestore_admin/client.py
View file
Open in desktop
Expand Up @@ -30,9 +30,9 @@
from google.auth.exceptions import MutualTLSChannelError # type: ignore
from google.oauth2 import service_account # type: ignore

from google.api_core import operation as ga_operation
from google.api_core import operation
from google.api_core import operation_async
from google.api_core import operation as ga_operation # type: ignore
from google.api_core import operation # type: ignore
from google.api_core import operation_async # type: ignore
from google.cloud.firestore_admin_v1.services.firestore_admin import pagers
from google.cloud.firestore_admin_v1.types import field
from google.cloud.firestore_admin_v1.types import field as gfa_field
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/firestore_admin_v1/services/firestore_admin/transports/base.py
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
import abc
import typing

from google import auth
from google import auth # type: ignore
from google.api_core import exceptions # type: ignore
from google.api_core import operations_v1 # type: ignore
from google.auth import credentials # type: ignore
Expand Down
4 changes: 4 additions & 0 deletions google/cloud/firestore_v1/__init__.py
View file
Open in desktop
Expand Up @@ -97,6 +97,10 @@
# from .types.write import DocumentDelete
# from .types.write import DocumentRemove
from .types.write import DocumentTransform
from typing import List

__all__: List[str]
__version__: str

# from .types.write import ExistenceFilter
# from .types.write import Write
Expand Down