feat: improve type information #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tseaver
previously requested changes
Aug 27, 2020
There was a problem hiding this comment.
@HemangChothani Please rebase / retarget your changes against the current master branch. The v2-staging branch is no longer active (@crwilcox force-pushed it to master last week).
product-auto-label
bot
added
the
api: firestore
… into firestore_improve_type
… into firestore_improve_type
tseaver
added
the
status: blocked
|
Blocked on #188. |
… into firestore_improve_type
tseaver
removed
the
status: blocked
… into firestore_improve_type
…ython-firestore into firestore_improve_type
|
@tseaver I think your comments are generally correct. Not sure my stance on optional vs union with none, but they should be ~equivalent. |
… into firestore_improve_type
… into firestore_improve_type
… into firestore_improve_type
|
@tseaver PTAL |
|
@tseaver I think your suggestions make sense. Unfortunately they are out of date so I cannot auto-apply I think Union with None is clearer what is going on with the return. |
tseaver
suggested changes
Oct 21, 2020
tseaver
reviewed
Oct 22, 2020
tseaver
approved these changes
Oct 23, 2020
crwilcox
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139